[FIX] Allow usage of after/before task assignment for all standard tasks #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
force-pushed
the
allow-task-assignment-generateBundle
branch
2 times, most recently
from
12fa0d4
to
4ecef82
Compare
When migrating an project from V2 to V3 the after/before task assignments of custom tasks often has to be adjusted because the task `uglify` got removed and new `minify` task is executed earlier as the `uglify` task. In the migration guide we have written that we can not make any assumptions about the task which should be used as the new "last" task executed by the standard UI5 Tooling build tasks. See https://sap.github.io/ui5-tooling/stable/updates/migrate-v3/#removal-of-standard-tasks-and-processors. In the above mentioned documentation we have a list with all tasks and the execution order. Currently, it works to assign a custom task after/before a task which is not executed at all. So you can assign a custom task to `afterTask: generateVersionInfo` although the task `generateVersionInfo` is not executed. This works for every standard UI5 Tooling build task except for `generateBundle`. This PR aligns the behaviour also for the `generateBundle` task. JIRA: CPOUI5FOUNDATION-724
matz3
force-pushed
the
allow-task-assignment-generateBundle
branch
from
4ecef82
to
4962e9e
Compare
d3xter666
reviewed
Sep 5, 2023
There was a problem hiding this comment.
I got from the description that we currently face issues only with generateBundle, but I also can see potential issues of the same kind in the following places:
lib/build/definitions/library.jsgenerateComponentPreloadtaskgenerateBundletask (already addressed in the comments)generateThemeDesignerResourcestask
lib/build/definitions/themeLibrary.jsgenerateThemeDesignerResourcestask
I'm unsure whether we need to address those now, but they seem the same.
matz3
previously requested changes
Sep 25, 2023
There was a problem hiding this comment.
I missed some detail when recommending to just use null as taskFunction.
The task logger used in runTasks must only receive the list of task which are actually executed and logged. Otherwise it will wait forever and the build never succeeds (you should be able to verify that e.g. with openui5-sample-app).
So the allTasks list must not include tasks which should not be executed. So the initial solution should be fine (using composeTaskList) as long as the logic is added after the include/excludes are handled because such a no-op task should never be enabled.
matz3
changed the title
flovogt
commented
Sep 26, 2023
matz3
approved these changes
Sep 27, 2023
d3xter666
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Oct 2, 2023
JIRA: CPOUI5FOUNDATION-724 This PR aims to improve the documentation by providing correct information based on a related change for custom tasks subscription & execution order behaviour: SAP/ui5-project#628 --------- Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows custom tasks to subscribe to any standard task, even disabled ones, ensuring custom tasks' execution and the correct order.
Background information:
When transitioning a project from V2 to V3, we often need to adjust the before/after task assignments for custom tasks due to the removal of the
uglifytask. The newminifytask now runs earlier than the previousuglifytask.Developers typically used
uglifyas the last enabled standard task to subscribe to.You can find updated documentation here: SAP/ui5-tooling#874
JIRA: CPOUI5FOUNDATION-724