Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Rename ui5HomeDir to ui5DataDir in APIs #707

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Feb 23, 2024

BREAKING CHANGE:
Installers and Resolvers' argument ui5HomeDir is now renamed to ui5DataDir

JIRA: CPOUI5FOUNDATION-802
Relates to: SAP/ui5-tooling#701

@d3xter666 d3xter666 changed the title [BREAKING] Rename ui5HomeDir to ui5DataDir [BREAKING] Rename ui5HomeDir to ui5DataDir in APIs Feb 23, 2024
@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

coverage: 95.761%. remained the same
when pulling 715dead on braking-v4-homedir-rename
into cf43a7a on main.

@RandomByte
Copy link
Member

Please add paragraph starting with BREAKING CHANGE: to the commit body, explaining which APIs are affected and how

@d3xter666 d3xter666 requested a review from a team February 26, 2024 08:32
@d3xter666 d3xter666 merged commit 5103c3e into main Feb 29, 2024
17 checks passed
@d3xter666 d3xter666 deleted the braking-v4-homedir-rename branch February 29, 2024 07:11
d3xter666 added a commit to SAP/ui5-cli that referenced this pull request Feb 29, 2024
BREAKING CHANGE:
`@ui5/project`'s Installers' and Resolvers' argument `ui5HomeDir` is now
renamed to `ui5DataDir`

JIRA: CPOUI5FOUNDATION-802
Relates to: SAP/ui5-tooling#701
Depends on: SAP/ui5-project#707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants