[FEATURE] Add specification version 1.1 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
spec-version-1.1
branch
from
f466f5e
to
896ca9e
Compare
matz3
previously approved these changes
Jan 10, 2020
The new 'theme-library' type requires spec version 1.1: SAP/ui5-builder#285 Also change wording of the error message for unsupported spec versions and fix the referenced URL. This should make it clear that the used version of the UI5 CLI might be outdated.
RandomByte
force-pushed
the
spec-version-1.1
branch
from
896ca9e
to
f6e643a
Compare
matz3
reviewed
Jan 10, 2020
| throw new Error( | ||
| `Unsupported specification version ${project.specVersion} defined for project ` + | ||
| `${project.id}. ` + | ||
| `See https://github.com/SAP/ui5-project/blob/master/docs/Configuration.md#specification-versions`); |
There was a problem hiding this comment.
Maybe also adopt the old Configuration.md file to point to the #specifiction-version anchor? Currently it just points to the Configuration page.
There was a problem hiding this comment.
Done by adding an additional link. The old Configuration.md also contained more than just the Specification Versions documentation.
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jan 10, 2020
The new type 'theme-library' requires this spec version 1.1. See SAP/ui5-project#252 and SAP/ui5-builder#285
matz3
approved these changes
Jan 10, 2020
RandomByte
changed the title
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jan 13, 2020
The new type 'theme-library' requires this spec version 1.1. See SAP/ui5-project#252 and SAP/ui5-builder#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 'theme-library' type requires spec version 1.1:
SAP/ui5-builder#285
Also change wording of the error message for unsupported spec versions
and fix the referenced URL. This should make it clear that the used
version of the UI5 CLI might be outdated.