Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] projectPreprocessor: Log warning when using a deprecated or restricted dependency #268

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

RandomByte
Copy link
Member

Projects in the tree that are not the root project may trigger a warning
log if they configure any of the following metadata flags:

  • deprecated: true
  • sapInternal: true

The latter may not trigger a warning if its parent project defines a
metadata flag "allowSapInternal: true".

@RandomByte RandomByte requested a review from matz3 March 5, 2020 15:28
… restricted dependency

Projects in the tree that are not the root project may trigger a warning
log if they configure any of the following metadata flags:
- deprecated: true
- sapInternal: true

The latter may not trigger a warning if its parent project defines a
metadata flag "allowSapInternal: true".
@RandomByte RandomByte force-pushed the deprecated-internal-warnings branch from efcd106 to b15aae3 Compare March 5, 2020 16:09
@RandomByte RandomByte changed the title [FEATURE] projectPreprocessor: Log warning when using a deprecated or restricted depdency [FEATURE] projectPreprocessor: Log warning when using a deprecated or restricted dependency Mar 5, 2020
@coveralls
Copy link

coveralls commented Mar 5, 2020

Coverage Status

Coverage increased (+0.3%) to 83.888% when pulling 3888f71 on deprecated-internal-warnings into f132eb5 on master.

t.deepEqual(logWarnSpy.getCall(0).args[0],
"Dependency my.project is deprecated and should not be used for new projects!",
"Logged expected warning message");
mock.stop("@ui5/logger");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also use mock.stopAll() within test.afterEach.always to ensure a proper cleanup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@RandomByte RandomByte merged commit b776a4f into master Mar 9, 2020
@RandomByte RandomByte deleted the deprecated-internal-warnings branch March 9, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants