[FIX] Properly resolve dependent shimmed modules #611
Closed
+78
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
added a commit
that referenced
this pull request
May 17, 2023
If a visited module did not resolve to any specification (project or extensions), try recreating the module when visiting it again from a different parent. Resolves SAP/ui5-tooling#807 This is an alternative to #611 This change might have a greater impact on performance since er might recreate modules that are not relevant to UI5 Tooling more than once if they are listed multiple times in the dependency tree. Before this change, such modules where only visited once.
|
A better solution has been proposed |
RandomByte
added a commit
that referenced
this pull request
May 22, 2023
If a visited module did not resolve to any specification (project or extensions), try recreating the module when visiting it again from a different parent. Resolves SAP/ui5-tooling#807 This is an alternative to #611 This change might have a greater impact on performance since er might recreate modules that are not relevant to UI5 Tooling more than once if they are listed multiple times in the dependency tree. Before this change, such modules where only visited once. --------- Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SAP/ui5-tooling#807
If an external (non-UI5) module is provided as devDependency in an application, but there's a dependecy to a sub-module that uses the external module as a main dependency and is shimmed there, it's been cached without the shim and is not build properly later.
Sample structure: