Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] MiddlewareUtil: Add getProject/getDependencies/resourceFactory API to interface #547

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Nov 28, 2022

New API is only available to custom middleware defining specVerson 3.0 and later.

Based on RFC 0012 UI5 Tooling Extension API v3

Depends on SAP/ui5-project#431

JIRA: CPOUI5FOUNDATION-568

@RandomByte RandomByte changed the title [FEATURE] TaskUtil: Add getProject/getDependencies API to interface [FEATURE] MiddlewareUtil: Add getProject/getDependencies API to interface Nov 28, 2022
matz3
matz3 previously approved these changes Nov 28, 2022
lib/middleware/MiddlewareManager.js Show resolved Hide resolved
lib/middleware/MiddlewareUtil.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 28, 2022

Coverage Status

Coverage decreased (-0.1%) to 93.056% when pulling 5e77ea5 on middlewareUtil-v3 into a0e8eed on main.

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@RandomByte RandomByte changed the title [FEATURE] MiddlewareUtil: Add getProject/getDependencies API to interface [FEATURE] MiddlewareUtil: Add getProject/getDependencies/resourceFactory API to interface Nov 29, 2022
@RandomByte RandomByte merged commit ab28f78 into main Nov 29, 2022
@RandomByte RandomByte deleted the middlewareUtil-v3 branch November 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants