Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Adapt tests to new behavior of FileSystem._runGlob which now throws for GLOB errors #192

Merged
merged 1 commit into from
May 28, 2019

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented May 27, 2019

See SAP/ui5-fs#140

The tmp directory might not be present during the execution of this
test. However, its usage didn't really add any value to the test
anyways.

@coveralls
Copy link

coveralls commented May 27, 2019

Coverage Status

Coverage remained the same at 93.284% when pulling 357d102 on static-exclude into 4d971b4 on master.

…ow throws for GLOB errors

See SAP/ui5-fs#140

The tmp directory might not be present during the execution of this
test. However, its usage didn't really add any value to the test
anyways.
@RandomByte RandomByte changed the title Adapt tests to new behavior of FileSystem._runGlob which now throws for GLOB errors [INTERNAL] Adapt tests to new behavior of FileSystem._runGlob which now throws for GLOB errors May 28, 2019
@RandomByte RandomByte requested a review from svbender May 28, 2019 09:28
@RandomByte RandomByte merged commit d2175f4 into master May 28, 2019
@RandomByte RandomByte deleted the static-exclude branch May 28, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants