Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Improve documentation after code refactoring #874

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Sep 20, 2023

JIRA: CPOUI5FOUNDATION-724

This PR aims to improve the documentation by providing correct information based on a related change for custom tasks subscription & execution order behaviour: SAP/ui5-project#628

Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 requested a review from KlattG September 27, 2023 12:24
d3xter666 added a commit to SAP/ui5-project that referenced this pull request Sep 27, 2023
…sks (#628)

This change allows custom tasks to subscribe to any standard task, even
disabled ones, ensuring custom tasks' execution and the correct order.

Background information:
When transitioning a project from V2 to V3, we often need to adjust the
before/after task assignments for custom tasks due to the removal of the
`uglify` task. The new `minify` task now runs earlier than the previous
`uglify` task.
Developers typically used `uglify` as the last enabled standard task to
subscribe to.

You can find updated documentation here:
SAP/ui5-tooling#874

JIRA: CPOUI5FOUNDATION-724

---------

Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com>
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor points.

docs/pages/extensibility/CustomTasks.md Outdated Show resolved Hide resolved
docs/pages/extensibility/CustomTasks.md Outdated Show resolved Hide resolved
docs/updates/migrate-v3.md Outdated Show resolved Hide resolved
d3xter666 and others added 3 commits September 28, 2023 09:39
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
docs/updates/migrate-v3.md Outdated Show resolved Hide resolved
@d3xter666 d3xter666 merged commit 3db938f into main Oct 2, 2023
7 checks passed
@d3xter666 d3xter666 deleted the update-docs-for-tasks branch October 2, 2023 06:35
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion.

docs/updates/migrate-v3.md Show resolved Hide resolved
d3xter666 added a commit that referenced this pull request Oct 4, 2023
Addresses the outstanding comments from this PR:
#874

#874 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants