[INTERNAL] Configuration: Document default for bundle definition "aync" flag #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
approved these changes
Jun 25, 2024
d3xter666
approved these changes
Jun 26, 2024
codeworrior
reviewed
Jun 26, 2024
| @@ -702,7 +702,7 @@ A list of bundle definitions. A `bundleDefinition` contains of the following opt | |||
| - `declareRawModules`: Whether raw modules should be declared after jQuery.sap.global became available. With the usage of the ui5loader, this flag should be set to 'false'. By default set to `false` | |||
| - `renderer`: Whether renderers for controls should be added to the module set. By default set to `false` | |||
| - `sort`: By default, modules are sorted by their dependencies. The sorting can be suppressed by setting the option to `false` | |||
| - `async`: Specifies whether the require section of the module should be asynchronous. When set to `true`, the modules will be loaded using sap.ui.require instead of sap.ui.requireSync. The latter API is not available in UI5 version 2.x. **Note:** This property is available only for `mode=require` | |||
| - `async`: Specifies whether the require section of the module should be asynchronous. When set to `true`, the modules will be loaded using sap.ui.require instead of sap.ui.requireSync. The latter API is not available in UI5 version 2.x. **Note:** This property is available only for `mode=require` and defaults to `true` | |||
There was a problem hiding this comment.
Not related to this change, but when reviewing the file as a whole I noticed that the nesting doesn't seem to be right. "sections" should be on the same level as "defaultFileTypes", shouldn't it? Strangely, it looks still okay in the V4 documentation 1, but not when previewing the MD file in the code section of the Github WebUI 2
Footnotes
There was a problem hiding this comment.
Thanks, @codeworrior !
Indeed, there was indentation before the "sections" item and GH treats this as subitem.
I fixed it with #970
matz3
reviewed
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.