From 81872809fc6f1fd121e73dcac3e33b1a7d202885 Mon Sep 17 00:00:00 2001
From: Martin Hristov <martin.r.hristov@gmail.com>
Date: Thu, 21 May 2020 11:12:45 +0300
Subject: [PATCH 1/2] fix(ui5-dialog): restrict max height and width based on
 spec

FIXES: https://github.com/SAP/ui5-webcomponents/issues/1662
---
 packages/main/src/themes/Dialog.css  |  5 +++
 packages/main/src/themes/Popup.css   |  2 ++
 packages/main/test/pages/Dialog.html | 50 +++++++++++++++++++++++++++-
 3 files changed, 56 insertions(+), 1 deletion(-)

diff --git a/packages/main/src/themes/Dialog.css b/packages/main/src/themes/Dialog.css
index 2c88922eb550..498979c41a38 100644
--- a/packages/main/src/themes/Dialog.css
+++ b/packages/main/src/themes/Dialog.css
@@ -15,6 +15,11 @@
 	height: 100%;
 }
 
+:host([stretch][on-phone]) .ui5-popup-root{
+	max-height: 100vh;
+	max-width: 100vw;
+}
+
 .ui5-popup-root {
 	display: flex;
 	flex-direction: column;
diff --git a/packages/main/src/themes/Popup.css b/packages/main/src/themes/Popup.css
index 0e2709cea62e..5f6530f86abb 100644
--- a/packages/main/src/themes/Popup.css
+++ b/packages/main/src/themes/Popup.css
@@ -18,6 +18,8 @@
 	display: flex;
 	flex-direction: column;
 	overflow: hidden;
+	max-height: 94vh;
+	max-width: 90vw;
 }
 
 @media screen and (-ms-high-contrast: active) {
diff --git a/packages/main/test/pages/Dialog.html b/packages/main/test/pages/Dialog.html
index b7068b917af2..0afa55806b1e 100644
--- a/packages/main/test/pages/Dialog.html
+++ b/packages/main/test/pages/Dialog.html
@@ -43,6 +43,54 @@
 	<ui5-dialog id="msg-dialog" header-text="Message dialog">
 		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
 			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
+		<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
+			That´s OpenUI5.</p>
 
 		<div slot="footer" style="display: flex; justify-content: flex-end; width: 100%; padding: .25rem 1rem;">
 			<ui5-button design="Emphasized">OK</ui5-button>
@@ -107,7 +155,7 @@
 
 		<ui5-button id='popbtn'>Open Popover</ui5-button>
 
-	
+
 
 		<br>
 		<br>

From 07cfcf828af3ddbb0ea1b8957d7169196af52d80 Mon Sep 17 00:00:00 2001
From: Martin Hristov <martin.r.hristov@gmail.com>
Date: Thu, 21 May 2020 11:14:25 +0300
Subject: [PATCH 2/2] space

---
 packages/main/src/themes/Dialog.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/main/src/themes/Dialog.css b/packages/main/src/themes/Dialog.css
index 498979c41a38..2e11aa229dbd 100644
--- a/packages/main/src/themes/Dialog.css
+++ b/packages/main/src/themes/Dialog.css
@@ -15,7 +15,7 @@
 	height: 100%;
 }
 
-:host([stretch][on-phone]) .ui5-popup-root{
+:host([stretch][on-phone]) .ui5-popup-root {
 	max-height: 100vh;
 	max-width: 100vw;
 }