From f0590d062dc0348b58ae03dae2d3b0181c1c5883 Mon Sep 17 00:00:00 2001 From: Vladislav Tasev Date: Thu, 2 May 2019 14:12:54 +0300 Subject: [PATCH 1/2] fix: tab container includes tab and tab container --- packages/main/src/TabContainer.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/main/src/TabContainer.js b/packages/main/src/TabContainer.js index 8e73254aaf37..d4d6ec678d19 100644 --- a/packages/main/src/TabContainer.js +++ b/packages/main/src/TabContainer.js @@ -12,6 +12,8 @@ import Icon from "./Icon.js"; import List from "./List.js"; import Popover from "./Popover.js"; import TabBase from "./TabBase.js"; +import Tab from "./Tab.js"; +import TabSeparator from "./TabSeparator.js"; // Styles import tabContainerCss from "./themes/TabContainer.css.js"; @@ -364,6 +366,8 @@ class TabContainer extends UI5Element { Icon.define(), List.define(), Popover.define(), + Tab.define(), + TabSeparator.define(), ]); super.define(...params); From 65d3364083082c197585b32c4e1e708154e53892 Mon Sep 17 00:00:00 2001 From: Vladislav Tasev Date: Thu, 2 May 2019 14:56:13 +0300 Subject: [PATCH 2/2] alternative approach --- packages/main/src/TabContainer.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/main/src/TabContainer.js b/packages/main/src/TabContainer.js index d4d6ec678d19..add7490104f9 100644 --- a/packages/main/src/TabContainer.js +++ b/packages/main/src/TabContainer.js @@ -12,8 +12,6 @@ import Icon from "./Icon.js"; import List from "./List.js"; import Popover from "./Popover.js"; import TabBase from "./TabBase.js"; -import Tab from "./Tab.js"; -import TabSeparator from "./TabSeparator.js"; // Styles import tabContainerCss from "./themes/TabContainer.css.js"; @@ -151,7 +149,9 @@ const metadata = { * * import "@ui5/webcomponents/dist/TabContainer"; *
- * Note: This also includes the ui5-tab and ui5-tab-separator Web Components. + * import "@ui5/webcomponents/dist/Tab"; (for ui5-tab) + *
+ * import "@ui5/webcomponents/dist/TabSeparator"; (for ui5-tab-separator) * * @constructor * @author SAP SE @@ -366,8 +366,6 @@ class TabContainer extends UI5Element { Icon.define(), List.define(), Popover.define(), - Tab.define(), - TabSeparator.define(), ]); super.define(...params);