Better way to kill process #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #293 (comment), this change still keeps the desired behaviour of killing the process on CTRL-C, but it gives parent processes a chance to clean up.
|
I happened to be skimming through the code looking for something unrelated and noticed there's cleanup code 20 lines below this change that should probably be synced to remove the new listener. |
|
Possibly yes, it looked to me like there was some redundancy, but as I didn't author this package nor spent a lot of time analysing the code, I wasn't sure how refactoring it would impact other area's. Probably best for the package owner to have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #293 (comment), this change still keeps the desired behaviour of killing the process on CTRL-C, but it gives parent processes a chance to clean up.