Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordsmithing on manpage env Methods section #4579

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mwichmann
Copy link
Collaborator

This is the first part of a possible series aiming to "tighten up" wording in the manpage. This PR covers only the section on Environment Methods and Global Functions, and actually doesn't make it "shorter", but hoping it's still an improvement.

Doc-only change, no code/tests.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

Signed-off-by: Mats Wichmann <mats@linux.com>
@mwichmann mwichmann changed the title Wordsmithing on manpage env Methods section [skip appveyor] Wordsmithing on manpage env Methods section Jul 25, 2024
@mwichmann
Copy link
Collaborator Author

Here is the converted-to-txt before and after - just the affected section, since it's localized.

diff.zip

and ellipses (<literal>...</literal>) indicate possible repetition.
Positional vs. keyword arguments are usually detailed
in the following text, not in the signature itself.
The &Python; positional-only (<literal>/</literal>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this bit The Python positional-only (/) and keyword-only (*) markers are not used. We never refer to using that notation anywhere, so I think no need to say it's not needed here, and for the python neophyte it might just cause confusion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can demote it to a comment - want to keep a placeholder since it's possible the "not used" could change in future - there are some functions we can't correctly describe in the synopsis without using more Pythonic syntax, and have to leave to prose.

It came up for me because when I was working on that, the Python doc folks had just decided to reverse a previous policy of not using those special markers because "it might be confusing", in favor of being able to provide a more correct synopsis. Python docs, of course, are intended for Python users and we still suggest you don't need to know (much) Python so it's not quite the same. Though I still have a preference for having the manpage describe things "completely", which includes the synopsis of an official interface.

@bdbaddog bdbaddog merged commit c7a3c96 into SCons:master Aug 1, 2024
6 of 7 checks passed
@mwichmann mwichmann added this to the NextRelease milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants