Drop WatchKit hack. Supports Native SwiftUI animated image, using SDAnimatedImagePlayer #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use WKInterfaceObject SPI)
… WebImage view. Support watchOS as well :) Good SwiftUI
dreampiggy
force-pushed
the
refactory_new_animated_image_watchOS
branch
from
51fe5f9 to
411255b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve #64 #43
I added the animated image support on
WebImage. In the future, maybe we can create a new View type (calledAnimatedWebImage? something like that) to make it clear for usage. Which need massive refactory (Including protocol based struct inherency, POP)I test it on iOS/tvOS/macOS/watchOS, works as expected.