Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added functions for creating sRGB enabled textures from file / memory, etc. #177

Merged
merged 3 commits into from
Dec 25, 2022
Merged

added functions for creating sRGB enabled textures from file / memory, etc. #177

merged 3 commits into from
Dec 25, 2022

Conversation

EnokViking
Copy link
Contributor

@EnokViking EnokViking commented Dec 16, 2022 •
edited
Loading

..and removed some unused functions, sfTexture_setSrgb and sfTexture_loadFromFile.

eXpl0it3r
eXpl0it3r requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some documentation adjustments 🙂

include/SFML/Graphics/Texture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/Texture.h Show resolved Hide resolved
include/SFML/Graphics/Texture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/Texture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/Texture.h Outdated Show resolved Hide resolved
include/SFML/Graphics/Texture.h Outdated Show resolved Hide resolved
Bambo-Borris
Bambo-Borris approved these changes Dec 23, 2022
View reviewed changes
Copy link

@Bambo-Borris Bambo-Borris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out locally and compared C++ results to C ones and got the same end result.

@Bambo-Borris Bambo-Borris mentioned this pull request Dec 23, 2022
Closed
@eXpl0it3r eXpl0it3r merged commit e40235f into SFML:master Dec 25, 2022
@eXpl0it3r
Copy link
Member

Thanks a ton for getting this fixed! 🙂

@eXpl0it3r eXpl0it3r linked an issue Dec 25, 2022 that may be closed by this pull request
[Question] Loading sRGB textures #154
Closed
@eXpl0it3r eXpl0it3r mentioned this pull request Dec 25, 2022
Closed
mgrojo added a commit to mgrojo/CSFML that referenced this pull request Aug 6, 2023
@mgrojo
Update \see documentation with the new sfTexture_createSrgb funct…
8231382 
…ions

Delete reference to deleted `sfTexture_setSrgb`

See SFML#177
@mgrojo mgrojo mentioned this pull request Aug 6, 2023
Merged
eXpl0it3r pushed a commit that referenced this pull request Aug 7, 2023
@mgrojo @eXpl0it3r
Update \see documentation with the new sfTexture_createSrgb funct…
a80542d 
…ions

Delete reference to deleted `sfTexture_setSrgb`

See #177
@Castux Castux mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bambo-Borris Bambo-Borris Bambo-Borris approved these changes

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Loading sRGB textures
3 participants
@EnokViking @eXpl0it3r @Bambo-Borris