Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scancodes #197

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Implement scancodes #197

merged 1 commit into from
Jul 7, 2023

Conversation

ChrisThrasher
Copy link
Member

Implements SFML/SFML#1235

I expected this be harder but the scan code interface is actually very simple. It's the implementation in SFML where all the complexity lies.

Copy link

@shane-tran-whitmire shane-tran-whitmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I expected scancodes to be much more complicated.

Copy link
Contributor

@kimci86 kimci86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing changes to sfEvent.

@ChrisThrasher
Copy link
Member Author

This is missing changes to sfEvent.

I made those changes last night and pushed them multiple times but I can't get this PR thread to update. Here's proof.

@ChrisThrasher
Copy link
Member Author

Looks like this PR thread finally updated with the changes I made

@ChrisThrasher ChrisThrasher merged commit 1d56c6e into master Jul 7, 2023
@ChrisThrasher ChrisThrasher deleted the scancodes branch July 7, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants