use aggregate initialization to initialize #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
requested changes
Sep 28, 2024
ChrisThrasher
force-pushed
the
use_aggregate_init
branch
from
41a3db2
to
5020757
Compare
ChrisThrasher
approved these changes
Sep 28, 2024
kimci86
reviewed
Nov 1, 2024
| sfTime time; | ||
| time.microseconds = static_cast<int64_t>(amount) * 1000; | ||
| return time; | ||
| return {static_cast<int64_t>(amount * 1000)}; |
There was a problem hiding this comment.
For the record, bug here got fixed in #360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally think it is clearer than the variable + member assignments as the layout of sfColor is guranteed and known and this removes some intermediary variables.