From 2b915cece8c67bd0226927a19bb7f1e4da3b98d3 Mon Sep 17 00:00:00 2001 From: Chris Thrasher Date: Fri, 4 Aug 2023 13:42:01 -0600 Subject: [PATCH] Reenable compiler warnings --- .github/workflows/ci.yml | 1 + CMakeLists.txt | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6deaa6f..dcf67e9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,6 +82,7 @@ jobs: -DCMAKE_BUILD_TYPE=${{matrix.type.name}} \ -DIMGUI_DIR=$GITHUB_WORKSPACE/imgui \ -DSFML_ROOT=$GITHUB_WORKSPACE/sfml/install \ + -DIMGUI_SFML_WARNINGS_AS_ERRORS=ON \ ${{matrix.platform.flags}} \ ${{matrix.config.flags}} diff --git a/CMakeLists.txt b/CMakeLists.txt index b040e6e..f7da45d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -131,6 +131,17 @@ target_compile_definitions(ImGui-SFML IMGUI_USER_CONFIG="${IMGUI_SFML_CONFIG_NAME}" ) +option(IMGUI_SFML_WARNINGS_AS_ERRORS "Treat compiler warnings as errors" OFF) +if(MSVC) + target_compile_options(ImGui-SFML PRIVATE + $<$:/WX> + /W3) +elseif(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Clang)") + target_compile_options(ImGui-SFML PRIVATE + $<$:-Werror> + -Wall -Wextra -Wpedantic -Wshadow) +endif() + if(WIN32 AND MINGW) target_link_libraries(ImGui-SFML PUBLIC imm32) endif()