Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ADOT to essentials submodule due to dependency on cert-manager #92

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Refactor ADOT to essentials submodule due to dependency on cert-manager #92

merged 6 commits into from
Aug 1, 2023

Conversation

thepoppingone
Copy link
Contributor

@thepoppingone thepoppingone commented Jul 24, 2023 •
edited
Loading

santhoshratala
santhoshratala approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@santhoshratala santhoshratala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thepoppingone thepoppingone merged commit 9b0eacc into main Aug 1, 2023
5 checks passed
@thepoppingone thepoppingone deleted the refactor-adot branch August 1, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niroz89 niroz89 niroz89 left review comments

@santhoshratala santhoshratala santhoshratala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thepoppingone @niroz89 @santhoshratala