Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ GitHub flow targeting draft PRs #35

Closed
1 task done
Jord-Gui opened this issue Aug 24, 2023 · 5 comments
Closed
1 task done

♻️ GitHub flow targeting draft PRs #35

Jord-Gui opened this issue Aug 24, 2023 · 5 comments
Assignees
@Jord-Gui
Labels
Area: Backend Relates to backend development e.g. API, Database etc Type: Refactor A code quality improvement e.g. Tech debt

Comments

@Jord-Gui
Copy link
Member

Jord-Gui commented Aug 24, 2023 •
edited
Loading

Cc: @JackDevAU @bradystroud @leahy268

The GitHub flow is picking up draft PRs. As per feedback from @wicksipedia, we should discuss this.

Tasks
Preview Give feedback
@Jord-Gui
Copy link
Member Author

Jord-Gui commented Aug 24, 2023 •
edited
Loading

@bradystroud has mentioned that it could pick up Draft PRs that have no updates on them for e.g. more than 2 weeks. He also likes the idea of marking PRs as stale

@wicksipedia
Copy link
Member

I don't know if it was or not... was a general question

@Jord-Gui Jord-Gui changed the title ♻️ Edit GitHub flow to filter out PRs in draft state ♻️ GitHub flow targeting draft PRs Aug 24, 2023
@Jord-Gui Jord-Gui added Type: Refactor A code quality improvement e.g. Tech debt Area: Backend Relates to backend development e.g. API, Database etc labels Aug 25, 2023
@Jord-Gui
Copy link
Member Author

Jord-Gui commented Sep 6, 2023

As per discussion with @adamcogan, draft PRs are non-blocking so can be ignored by Dory.

@Jord-Gui Jord-Gui self-assigned this Sep 6, 2023
@Jord-Gui
Copy link
Member Author

Jord-Gui commented Sep 6, 2023

I've created another PBI #58 to investigate Power Automate flows marking GitHub PRs as stale

@Jord-Gui
Copy link
Member Author

Jord-Gui commented Sep 6, 2023

Done - flow now filters our draft PRs

@Jord-Gui Jord-Gui closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jord-Gui Jord-Gui

Labels
Area: Backend Relates to backend development e.g. API, Database etc Type: Refactor A code quality improvement e.g. Tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wicksipedia @Jord-Gui