Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️🔥Admin Portal - fix build action #1185

Merged
merged 1 commit into from
Jan 31, 2025
Merged

🛠️🔥Admin Portal - fix build action #1185

merged 1 commit into from
Jan 31, 2025

Conversation

vladislav-kir
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

#1145

  1. What was changed?

admin-build:

  • remove Build step
  • remove --no-build option from Publish step
  1. Did you do pair or mob programming?

No

@vladislav-kir
admin-build:
d2eb204 
- remove Build step
- remove --no-build option from Publish step
@vladislav-kir vladislav-kir requested a review from jernejk January 31, 2025 03:45
@vladislav-kir vladislav-kir self-assigned this Jan 31, 2025
jernejk
jernejk approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@jernejk jernejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet build should be redundant in this case.

@vladislav-kir vladislav-kir merged commit 8bff5a7 into main Jan 31, 2025
6 checks passed
@vladislav-kir vladislav-kir deleted the 1145-fix-admin-portal-build branch January 31, 2025 03:47
@jernejk jernejk linked an issue Feb 5, 2025 that may be closed by this pull request
🛠️🔥Admin Portal - Deployments are broken #1145
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernejk jernejk jernejk approved these changes

Assignees

@vladislav-kir vladislav-kir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️🔥Admin Portal - Deployments are broken
2 participants
@vladislav-kir @jernejk