🐛 Alumni profiles are broken

[piers-sinclair]

Cc: @Aibono1225

Hi @bradystroud

Describe the Bug

Alumni people profiles seem to be broken

To Reproduce

Steps to reproduce the behavior:

1. Go to https://www.ssw.com.au/rules/turn-emails-into-pbis/
2. Click on Damian Brady
3. see 404 error

Expected Behavior

See Damian Brady's people profile

Tasks

• Investigate
• Fix

Screenshots

Thanks!

[Aibono1225]

Based on my investigation, this issue occurs because in SSW.People we don't generate pages for people who no longer work for SSW.

Regarding this issue, I think we can choose one of these two solutions:

Solution 1:

Before taking users to the people profile page, check if it exists by making an HTTP request. If it's not found (404 error), don't send users to it.

Solution 2:

Leave it as it is.

[Aibono1225]

As per my conversation with @bradystroud , the redirection in SSW.People is not working as expected.
Normally, when people visit https://ssw.com.au/people/damian-brady, they should be redirected to https://ssw.com.au/people/damian-brady/ (with slash at the end). If this people is not working at SSW, users should then be redirected to https://ssw.com.au/people/alumni/damian-brady/.

Relevant code: https://github.com/SSWConsulting/SSW.People/blob/da001970536701628059ec5f3fdd435f17bd8b39/gatsby-node.js#L464C1-L480C6

• Investigate
• Make the redirect work in SSW.People

[Aibono1225]

⭐ Done - The issue has been fixed.