Migrated logo page to app router #3649
Open
+126
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from 9dbab6b |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3649.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3649.azurewebsites.net |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3649.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3649.azurewebsites.net |
amankumarrr
approved these changes
Feb 26, 2025
amankumarrr
approved these changes
Feb 26, 2025
| const seo = tinaProps.props.seo; | ||
|
|
||
| if (seo && !seo.canonical) { | ||
| seo.canonical = `${tinaProps.props.header.url}logo/${params.filename}`; |
There was a problem hiding this comment.
Suggested change
| seo.canonical = `${tinaProps.props.header.url}logo/${params.filename}`; | |
| seo.canonical = `${tinaProps.props.header.url}logo${params.filename ? `/${params.filename}`: ""}`; |
this is when the canonical is empty and params.filename is undefined for index page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected routes: /logo and /logo/*
Fixed ♻️ App Router migration - Logo #3166
If adding a new page, I have followed the 📃 New Webpage issue template
Include done video or screenshots
Figure: /logo page
Figure: /logo/ssw page