-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hpx::util::unwrapped doesn't work with non-future types #1400
Labels
Milestone
Comments
We just ran into this with Zahra. Would it be correct for non-future params to just wrap them into futures with |
I'd rather pass through non-future parameters unchanged, if possible. |
6 tasks
Naios
added a commit
to Naios/hpx
that referenced
this issue
Jul 24, 2017
* Use hpx::util::unwrap and hpx::util::unwrapping instead, that clearify which underlying implementation should be used (the immediate or the deferred one). The automatic implementation selection was broken since unwrapped allowed to pass non future arguments through. * Closes STEllAR-GROUP#1400 * Closes STEllAR-GROUP#1404 * Closes STEllAR-GROUP#2456 * Ref STEllAR-GROUP#1126 * Ref STEllAR-GROUP#1132
Naios
added a commit
to Naios/hpx
that referenced
this issue
Jul 24, 2017
* Use hpx::util::unwrap and hpx::util::unwrapping instead, that clearify which underlying implementation should be used (the immediate or the deferred one). The automatic implementation selection was broken since unwrapped allowed to pass non future arguments through. * Closes STEllAR-GROUP#1400 * Closes STEllAR-GROUP#1404 * Closes STEllAR-GROUP#2456 * Ref STEllAR-GROUP#1126 * Ref STEllAR-GROUP#1132
Naios
added a commit
to Naios/hpx
that referenced
this issue
Jul 25, 2017
* Use hpx::util::unwrap and hpx::util::unwrapping instead, that clearify which underlying implementation should be used (the immediate or the deferred one). The automatic implementation selection was broken since unwrapped allowed to pass non future arguments through. * Closes STEllAR-GROUP#1400 * Closes STEllAR-GROUP#1404 * Closes STEllAR-GROUP#2456 * Ref STEllAR-GROUP#1126 * Ref STEllAR-GROUP#1132
Naios
added a commit
to Naios/hpx
that referenced
this issue
Jul 25, 2017
* Use hpx::util::unwrap and hpx::util::unwrapping instead, that clearify which underlying implementation should be used (the immediate or the deferred one). The automatic implementation selection was broken since unwrapped allowed to pass non future arguments through. * Closes STEllAR-GROUP#1400 * Closes STEllAR-GROUP#1404 * Closes STEllAR-GROUP#2456 * Ref STEllAR-GROUP#1126 * Ref STEllAR-GROUP#1132
Naios
added a commit
to Naios/hpx
that referenced
this issue
Jul 25, 2017
* Use hpx::util::unwrap and hpx::util::unwrapping instead, that clearify which underlying implementation should be used (the immediate or the deferred one). The automatic implementation selection was broken since unwrapped allowed to pass non future arguments through. * Closes STEllAR-GROUP#1400 * Closes STEllAR-GROUP#1404 * Closes STEllAR-GROUP#2456 * Ref STEllAR-GROUP#1126 * Ref STEllAR-GROUP#1132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Making an
unwrapped
call in dataflow when one of the arguments isn't a future, we currently get a compile error.Example:
IMHO, all three examples above should work.
The text was updated successfully, but these errors were encountered: