Parallel equal #1193
Merged
Parallel equal #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| try { | ||
| return detail::algorithm_result<ExPolicy, bool>::get( | ||
| std::equal(first1, last1, first2, std::forward<F>(f))); |
There was a problem hiding this comment.
Should call the "binary" form of std::equal.
There was a problem hiding this comment.
The binary std::equal is new for C++14 only and does not exist for all compilers yet (for instance MSVC does not implement it yet).
There was a problem hiding this comment.
Then something else should be done, the two algorithms have different requirements. Ranges of different length are valid input to the "binary" std::equal, but not to the "unary" one.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 4 more algorithms related to #1141: Implement N3989 on top of HPX