Inclusive scan #1342
Merged
Inclusive scan #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: hpx/parallel/numeric.hpp
Closed
| char const* const name_; | ||
|
|
||
| friend class boost::serialization::access; | ||
|
|
||
| template <typename Archive> | ||
| void serialize(Archive& ar, unsigned int) | ||
| { |
There was a problem hiding this comment.
This is missing the name_ member, on purpose?
There was a problem hiding this comment.
The default constructors for the algorithms always set this value, no need to serialize it explicitly
There was a problem hiding this comment.
I see. wouldn't a static char const * Derived::name() be more appropriate than a distinct member?
There was a problem hiding this comment.
Either way would work. Both variations can be made constexpr later on.
|
What I miss here is a testcase for the scan partitioner. |
|
Well, all tests for the various scan algorithms test this partitioner, though indirectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
exclusive_scanandinclusive_scanalgorithm. This also addstransform_exclusive_scanandtransform_inclusive_scan. Irt also changes the implementation ofparallel::dispatchandparallel::remote::dispatchto use variadics.