-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add projection function to find_* (and fix very bad bug) #3436
Conversation
Thanks a lot! Please also fix the inspect errors reported here: https://30382-4455628-gh.circle-artifacts.com/0/hpx_inspect_report.html |
After a discussion with @K-ballo on chat, i have removed plain |
87fb532
to
cdb5f7a
Compare
Actually doing a projection version of find_if and find_if_not would mean having to do also do this for the segmented algorithms, so not doing it now. |
Fixed a critical bug which made find_end ignore user supplied predicate
@brjsp thanks for working on this. I have not followed all the discussion around this - could you give a short overview about the current state of this PR, please? |
@hkaiser find_end and find_first_of have added projection and range version, the bug in find_end is fixed, other functions are untouched, should be ready for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
@msimberg I think we can go ahead and merge this. There shouldn't be any interaction with other parts of HPX besides the algorithms themselves. |
This started as an attempt to make find_* Ranges TS compliant (see #1668). But during testing, i discovered and fixed a bad bug in find_end making it unusable with custom comparison operator.
Because of this bug, i am making this pull request now, before writing a container version of the above algorithms. The regular versions are already usable as given in this pull request.