Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding C++20 latch API #4635

Merged
merged 1 commit into from
May 19, 2020
Merged

Adding C++20 latch API #4635

merged 1 commit into from
May 19, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 17, 2020

  • adding hpx/latch.hpp that imports hpx::lcos::local::latch into namespace hpx
  • flyby: adding hpx/thread.hpp for compatibility

@hkaiser hkaiser added this to the 1.5.0 milestone May 17, 2020
@hkaiser hkaiser mentioned this pull request May 17, 2020
Closed
4 tasks
@hkaiser
Adding C++20 latch API
72ce9cf 
- adding hpx/latch.hpp that imports hpx::lcos::local::latch into namespace hpx
- flyby: adding hpx/thread.hpp for compatibility
msimberg
msimberg approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msimberg msimberg mentioned this pull request May 19, 2020
Merged
@hkaiser hkaiser merged commit b60943a into master May 19, 2020
@hkaiser hkaiser deleted the cpp20_latch branch May 19, 2020 16:13
aurianer
aurianer reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry late as usual, I have trouble to keep up with all the PRs :/

libs/synchronization/include/hpx/synchronization/latch.hpp
///
/// Requires: counter_ > 0.
/// Requires: counter_ >= n and n >= 0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update instead of n?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer left review comments

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: LCOs type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hkaiser @msimberg @aurianer