Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding C++20 barrier #4636

Merged
merged 1 commit into from
May 20, 2020
Merged

Adding C++20 barrier #4636

merged 1 commit into from
May 20, 2020

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 17, 2020

  • adding hpx/barrier.hpp that imports lcos::local::cpp20_barrier into namespace hpx

@hkaiser hkaiser added this to the 1.5.0 milestone May 17, 2020
@hkaiser hkaiser mentioned this pull request May 17, 2020
Closed
4 tasks
msimberg
msimberg previously approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've been busy, thanks! Do you know if we have any internal uses of barrier that should be replaced by the new one?

@hkaiser
Copy link
Member Author

hkaiser commented May 18, 2020 •
edited
Loading

You've been busy, thanks! Do you know if we have any internal uses of barrier that should be replaced by the new one?

I wanted to go through our code in a second sweep to replace things where possible.

@msimberg msimberg mentioned this pull request May 19, 2020
Merged
@hkaiser
Adding C++20 barrier
bbd6092 
- adding hpx/barrier.hpp that imports lcos::local::cpp20_barrier into namespace hpx
@hkaiser
Copy link
Member Author

hkaiser commented May 19, 2020

This should be good to go now.

@msimberg msimberg merged commit 796bc04 into master May 20, 2020
@msimberg msimberg deleted the cpp20_barrier branch May 20, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: LCOs type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hkaiser @msimberg