Adapting transform to C++20 (non-compilable PR) #4855

gonidelis · 2020-07-24T12:43:48Z

This is an early adaptation for transform. It includes:

adaptation for the end/begin iterators to be different in non-segmented transform
adaptation for the end/begin iterators to be different in segmented transform (didn't touch segmented_transform() functions though)
transform_projected specialization addition with util::projection_utility

To do

Add tests for the adaptations.

There is a compilation error when:

make tests.unit.modules.segmented_algorithms.partitioned_vector_transform_binary2 and
make tests.unit.modules.segmented_algorithms.partitioned_vector_transform_binary3

which I believe stems from the projection_identity addition but I can't figure out why.

Fix test compilation error for partitioned_vector_transform_binary2/3

Important

This is an early adaptation which aims to facilitate the final adaptation that will utilize CPOs.

…EPT_REQUIRES format

gonidelis · 2020-07-31T00:29:28Z

I have adapted the result types for all three overloads of transform. There are lots of compilation errors that come from the way tests are implemented. The errors stem from here:

hpx/libs/algorithms/tests/unit/algorithms/transform_tests.hpp

Lines 66 to 67 in 256b42e

    
           HPX_TEST(hpx::util::get<0>(result) == iterator(std::end(c))); 
        
           HPX_TEST(hpx::util::get<1>(result) == std::end(d));

and here:

hpx/libs/algorithms/tests/unit/algorithms/transform_tests.hpp

Line 94 in 256b42e

hpx::util::tuple<iterator, base_iterator> result = f.get();

hpx/libs/algorithms/tests/unit/algorithms/transform_tests.hpp

Line 162 in 256b42e

f.get();

as there is no get() function implemented for in_out_result or in_in_out_result types. I would like to discuss with @hkaiser on how to fix that.

I need to add a projection_identity specialization for transform_binary_projected.

After fixing the compilation issues on the tests, I think I should finally proceed on creating the CPO's.

…nd fix decay issue

libs/algorithms/include/hpx/parallel/algorithms/transform.hpp

hkaiser · 2020-08-07T01:32:09Z

libs/algorithms/include/hpx/parallel/algorithms/transform.hpp

        {
-            return get_function_address<
-                typename hpx::util::decay<F>::type>::call(f.f_);
+            return std::transform(first, last, dest);


Calling the standard algorithms will have the correct semantics, but exposes inconsistent exception behavior. For the other algorithms we have settled on relying our own implementations even in those cases where semantically the standard version would be sufficient.

libs/algorithms/tests/unit/algorithms/transform_binary_tests.hpp

libs/functional/include/hpx/functional/tag_invoke.hpp

aurianer

Very nice ;)

aurianer · 2020-08-07T08:19:52Z

libs/algorithms/include/hpx/parallel/algorithms/transform.hpp

+                    traits::projected<Proj, FwdIter1>>::value
+        )>
+    //clang-format on
+    HPX_DEPRECATED("hpx::parallel::transform is deprecated, use hpx::transform instead")


@hkaiser should we use the HPX_DEPRECATED_V macro here?

Yes, that's what we use everywhere else now.

aurianer · 2020-08-07T10:39:55Z

libs/algorithms/include/hpx/parallel/util/transform_loop.hpp

@@ -53,7 +53,7 @@ namespace hpx { namespace parallel { namespace util {
        {
            template <typename InIter1, typename InIter2, typename OutIter,
                typename F>
-            HPX_HOST_DEVICE HPX_FORCEINLINE static hpx::util::tuple<InIter1,
+            HPX_HOST_DEVICE HPX_FORCEINLINE static util::in_in_out_result<InIter1,
                InIter2, OutIter>
            call(InIter1 first1, InIter1 last1, InIter2 first2, OutIter dest,


You may also want to adapt the begin/end iter template arguments for transform_loop too

Got it! Thanks!

gonidelis · 2020-08-09T12:31:48Z

This PR is closed and archieved. The transform C++20 adaptation will take place in ~~a new PR~~ #5051.

gonidelis added 7 commits July 16, 2020 16:41

Add deprecation warning on hpx::paralllel::transform and fix HPX_CONC…

044ec54

…EPT_REQUIRES format

Adapt transform begin-end iterator

fbfd291

Add projection_identity specialization on transform_projected

02a8dad

Fix adapted transform documentation and format

002f21d

Adapt transform sequential/ parallel versions in detail namespace

a41fa3f

Adapt transform segmented end-begin iterators

382d521

Merge branch 'master' into transform_adapt

9eefbc5

hkaiser mentioned this pull request Jul 28, 2020

Adapt parallel algorithms to C++20 #4822

Closed

51 tasks

Replace std::distance with detail::distance in parallel:transform

32a1af8

gonidelis force-pushed the transform_adapt branch from a628a03 to 4c09b6c Compare July 30, 2020 21:21

Adapt parallel::transform result type

bfa3757

gonidelis force-pushed the transform_adapt branch 2 times, most recently from d7bb53e to fc6c343 Compare July 30, 2020 23:47

Add in_in_out_result and adapt corresponding transform result types

7d3f37c

gonidelis force-pushed the transform_adapt branch from fc6c343 to 7d3f37c Compare July 30, 2020 23:53

Adapt transform result types completely (and clang-format)

993acc5

gonidelis force-pushed the transform_adapt branch from a6c7a1c to 993acc5 Compare July 31, 2020 00:19

gonidelis added 5 commits July 30, 2020 19:48

Add projection_identity specialization on trasform_binary_projected a…

e24deb0

…nd fix decay issue

Fix result types on transform tests

496e0a3

Fix tag function object result type

b861ff2

Move get_second_element from copy.hpp to result_types.hpp

0da10a8

Add hpx::transform CPO

40523e7

hkaiser reviewed Aug 7, 2020

View reviewed changes

libs/algorithms/include/hpx/parallel/algorithms/transform.hpp Show resolved Hide resolved

hkaiser reviewed Aug 7, 2020

View reviewed changes

libs/algorithms/tests/unit/algorithms/transform_binary_tests.hpp Show resolved Hide resolved

hkaiser reviewed Aug 7, 2020

View reviewed changes

libs/functional/include/hpx/functional/tag_invoke.hpp Show resolved Hide resolved

aurianer reviewed Aug 7, 2020

View reviewed changes

gonidelis changed the title ~~Transform adapt~~ Adapting transform to C++20 Aug 7, 2020

hkaiser mentioned this pull request Aug 8, 2020

Parallel algorithms should accept iterator/sentinel pairs #3646

Closed

45 tasks

gonidelis closed this Aug 9, 2020

gonidelis changed the title ~~Adapting transform to C++20~~ Adapting transform to C++20 (non-compilable PR) Aug 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapting transform to C++20 (non-compilable PR) #4855

Adapting transform to C++20 (non-compilable PR) #4855

gonidelis commented Jul 24, 2020 •

edited

Loading

gonidelis commented Jul 31, 2020 •

edited

Loading

hkaiser Aug 7, 2020

aurianer left a comment

aurianer Aug 7, 2020

hkaiser Aug 7, 2020

aurianer Aug 7, 2020

gonidelis Aug 7, 2020

gonidelis commented Aug 9, 2020 •

edited

Loading

Adapting transform to C++20 (non-compilable PR) #4855

Adapting transform to C++20 (non-compilable PR) #4855

Conversation

gonidelis commented Jul 24, 2020 • edited Loading

To do

Important

gonidelis commented Jul 31, 2020 • edited Loading

hkaiser Aug 7, 2020

Choose a reason for hiding this comment

aurianer left a comment

Choose a reason for hiding this comment

aurianer Aug 7, 2020

Choose a reason for hiding this comment

hkaiser Aug 7, 2020

Choose a reason for hiding this comment

aurianer Aug 7, 2020

Choose a reason for hiding this comment

gonidelis Aug 7, 2020

Choose a reason for hiding this comment

gonidelis commented Aug 9, 2020 • edited Loading

gonidelis commented Jul 24, 2020 •

edited

Loading

gonidelis commented Jul 31, 2020 •

edited

Loading

gonidelis commented Aug 9, 2020 •

edited

Loading