Adapt replace(_if) to C++20 #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonidelis
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
gonidelis
force-pushed
the
replace_adapt
branch
2 times, most recently
from
79fb065 to
df45984
Compare
This was referenced Feb 22, 2021
hkaiser
reviewed
Feb 22, 2021
hkaiser
reviewed
Feb 22, 2021
hkaiser
reviewed
Feb 22, 2021
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Feb 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
gonidelis
force-pushed
the
replace_adapt
branch
from
251864d to
6f12434
Compare
gonidelis
force-pushed
the
replace_adapt
branch
2 times, most recently
from
24035b6 to
dc92a8a
Compare
hkaiser
reviewed
Feb 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/replace.hpp
Outdated
Show resolved
Hide resolved
gonidelis
force-pushed
the
replace_adapt
branch
from
dc92a8a to
60dd21c
Compare
|
@hkaiser Should I also provide docs for the result types (e.g. |
That would be nice. You can add the docs as doxygen comments close to the actual types. Feel free to steal the text from rangev3, if available there. |
|
This should be ok now, once CI gets greeny. |
aurianer
reviewed
Mar 1, 2021
| /// (deduced). | ||
| /// \tparam T The type of the new values to replace (deduced). | ||
| /// | ||
| /// \param policy The execution policy to use for the scheduling of |
| /// output iterator. | ||
| /// \tparam T The type of the old and new values (deduced). | ||
| /// | ||
| /// \param policy The execution policy to use for the scheduling of |
Jedi18
reviewed
Mar 9, 2021
| FwdIter2 dest, T1 const& old_value, T2 const& new_value, | ||
| Proj&& proj = Proj()) | ||
| // clang-format off | ||
| template <typename ExPolicy, typename FwdIter1, typename Sent, |
There was a problem hiding this comment.
I know this PR has been merged but did you add typename Sent by mistake? Since last is of type FwdIter1 for this deprecated overload.
There was a problem hiding this comment.
@Jedi18 Great catch! Don't tell the boss, I will take care of it asap ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts
replace/replace_if/replace_copy/replace_copy_ifto C++20.Please don't merge yet, docs will be added soon.