Adapt exclusive_scan to C++20 #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
Jedi18
force-pushed
the
adapt_exclusive_scan
branch
5 times, most recently
from
2130384 to
0856684
Compare
This was referenced Jul 9, 2021
Jedi18
force-pushed
the
adapt_exclusive_scan
branch
from
0856684 to
ab04639
Compare
|
@hkaiser Why is this issue's type breaking change? |
My mistake, thanks for spotting! |
46 tasks
hkaiser
reviewed
Jul 21, 2021
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_exclusive_scan
branch
from
ab04639 to
288961b
Compare
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/exclusive_scan.hpp
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_exclusive_scan
branch
from
de99924 to
99de280
Compare
|
Can one of the admins verify this patch? |
|
@Jedi18 After merging one of the other algorithm PRs this one (and others) has conflicts. Could you fix those, please? |
|
@hkaiser Sure, I'll rebase them on top of each other so we don't have to fix conflicts for every merge. |
…nsform_exclusive_scan
…ads and constexpr sequential functions
Jedi18
force-pushed
the
adapt_exclusive_scan
branch
from
99de280 to
874d8de
Compare
|
Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan |
msimberg
pushed a commit
that referenced
this pull request
Aug 6, 2021
Adapt exclusive_scan to C++20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted exclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668
Issue #5156