Adapt swap_ranges to C++ 20 #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
Jedi18
force-pushed
the
adapt_swap_ranges
branch
from
9b76920 to
f11a4d7
Compare
hkaiser
reviewed
Jul 15, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/swap_ranges.hpp
Outdated
Show resolved
Hide resolved
This was referenced Jul 15, 2021
Jedi18
force-pushed
the
adapt_swap_ranges
branch
from
0f4c25c to
77ac144
Compare
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/swap_ranges.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/swap_ranges.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 23, 2021
libs/parallelism/algorithms/include/hpx/parallel/container_algorithms/swap_ranges.hpp
Outdated
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_swap_ranges
branch
from
6329150 to
618eed7
Compare
|
Can one of the admins verify this patch? |
…e implementation to support sentinels
Jedi18
force-pushed
the
adapt_swap_ranges
branch
from
618eed7 to
01e32b8
Compare
Jedi18
force-pushed
the
adapt_swap_ranges
branch
from
01e32b8 to
3ed027d
Compare
|
add to whitelist |
|
retest cscs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted swap_ranges to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668