Add shift_left and shift_right algorithms #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
add to whitelist |
Jedi18
force-pushed
the
add_shift_algorithms
branch
4 times, most recently
from
899f989 to
675ebd4
Compare
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
This was referenced Aug 18, 2021
Jedi18
force-pushed
the
add_shift_algorithms
branch
from
675ebd4 to
3ad8eea
Compare
hkaiser
previously approved these changes
Aug 31, 2021
|
@Jedi18 same here: could you please fix the conflict so we can go ahead and merge the PR? |
Jedi18
force-pushed
the
add_shift_algorithms
branch
2 times, most recently
from
df5f806 to
cba0a27
Compare
|
@Jedi18 could you please fix the formatting errors? You can ignore the inspect errors. They've been fixed on master. |
Jedi18
force-pushed
the
add_shift_algorithms
branch
from
cba0a27 to
f93cdab
Compare
|
Sorry didn't notice those. Fixed the formatting errors. |
Jedi18
force-pushed
the
add_shift_algorithms
branch
from
f93cdab to
770133a
Compare
Jedi18
force-pushed
the
add_shift_algorithms
branch
from
770133a to
d1c3e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shift_left and shift_right algorithms.
Any background context you want to provide?
Closes #3706
Issue #4822