Adjacent

[kmoham6]

Adapting adjacent_difference to C++20

[hkaiser]

Could you please update the docs as well:

• https://github.com/STEllAR-GROUP/hpx/blob/master/docs/sphinx/api/public_api.rst and
• https://github.com/STEllAR-GROUP/hpx/blob/master/docs/sphinx/manual/writing_single_node_hpx_applications.rst?

[hkaiser]

Also, please fix the compilation problems exposed by the CI.

[hkaiser]

@kmoham6 could you please take care of the remaining CI problems?

[hkaiser]

@kmoham6 after merging #5580 this PR has conflicts with master. Could you please look into fixing those? Also, things look much better now, there are only a few problems left, for instance: https://cdash.cscs.ch/viewBuildError.php?buildid=188148.

[StellarBot]

Performance test report

HPX Performance

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	++

Info

Property	Before	After
HPX Commit	254db57	64b8a73
HPX Datetime	2021-08-21T11:38:52+00:00	2021-10-29T14:53:00+00:00
Datetime	2021-08-23T15:21:22.855927+02:00	2021-10-29T17:09:39.414447+02:00
Hostname	nid00446	nid01146
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Clustername	daint	daint

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	-
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	-	-	-
Stream Benchmark - Copy	(=)	=	(=)

Info

Property	Before	After
HPX Commit	916f4d8	64b8a73
HPX Datetime	2021-10-22T15:54:13+00:00	2021-10-29T14:53:00+00:00
Datetime	2021-10-25T11:52:24.316784+02:00	2021-10-29T17:09:54.787120+02:00
Hostname	nid01196	nid01146
Compiler	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0	/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0
Envfile
Clustername	daint	daint

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

[hkaiser]

@kmoham6 the cmake_format issue should be gone if you rebase on master. The other test issues are unrelated and known, you will not have to worry about those.

[msimberg]

@kmoham6 could you mark comments that you've already taken care of as resolved so that we can see what is actually still unresolved?

[hkaiser]

@kmoham6 not sure if I missed it before, but now we see compilation problems with the datapar tests: https://cdash.cscs.ch/viewBuildError.php?buildid=193713

[kmoham6]

@hkaiser seems the error is about std::minus<> that I changed it before my last rebase. it looks like they were lost after rebase. I fixed them and pushing again.

[hkaiser]

This is now ready to go in. LGTM, thanks!