Adapt simd adj diff #5580
Merged
Adapt simd adj diff #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 25, 2021 17:51
Moves sequential implementation of adjacent_difference to detail which enables overload for simd policy.
Replaces use of std minus with generic lambda which enables minus operations with data parallel types.
Adds new header in datapar for adjacent difference algorithm. Adds the new header in CMakeLists.txt and datapar.hpp.
Splits the existing adjacent_difference into header and source files. Merges execption and bad alloc tests into one header and source.
Adds adjacent difference datapar unit test source file.
srinivasyadav18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
hkaiser
reviewed
Sep 25, 2021
hkaiser
reviewed
Sep 25, 2021
libs/core/algorithms/include/hpx/parallel/algorithms/adjacent_difference.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Sep 25, 2021
libs/core/algorithms/include/hpx/parallel/datapar/adjacent_difference.hpp
Outdated
Show resolved
Hide resolved
aurianer
previously approved these changes
Sep 28, 2021
libs/core/algorithms/tests/unit/datapar_algorithms/adjacentdifference_datapar.cpp
Outdated
Show resolved
Hide resolved
libs/core/algorithms/tests/unit/datapar_algorithms/adjacentdifference_datapar.cpp
Outdated
Show resolved
Hide resolved
|
@srinivasyadav18 could you have a look at these please: https://cdash.cscs.ch/viewBuildError.php?buildid=185806. That's GCC 11 with C++20, if it makes a difference (I think it has more tests enabled because of that). |
This was referenced Oct 12, 2021
Merged
This was referenced Oct 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to fixing #2333
Proposed Changes