Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for data-parallelism for replace, replace_if, replace_copy, replace_copy_if algorithms #6033

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Support for data-parallelism for replace, replace_if, replace_copy, replace_copy_if algorithms #6033

merged 3 commits into from
Oct 5, 2022

Conversation

srinivasyadav18
Copy link
Contributor

Contributes to Fixing #2333

Proposed Changes

  • Moved replace algorithm implementation to detail/replace.hpp
  • Added datapar replace implementation
  • Added unit tests for datapar replace

@hkaiser hkaiser added this to the 1.9.0 milestone Oct 4, 2022
hkaiser
hkaiser requested changes Oct 4, 2022
View reviewed changes
libs/core/algorithms/include/hpx/parallel/datapar/replace.hpp
sequential_replace_t<ExPolicy>, ExPolicy&& policy, InIter first,
InIter last, T1 const& old_value, T2 const& new_value, Proj&& proj)
{
if constexpr (hpx::parallel::util::detail::iterator_datapar_compatible<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this to the HPX_CONCEPT_REQUIRES_ above, thus avoiding duplicating the else case below? This might also require adding the to_non_simd to the non-datapar case, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this PR as is and get back to the mentioned issue later.

@hkaiser
Copy link
Member

hkaiser commented Oct 5, 2022

bors merge

@bors
Copy link

bors bot commented Oct 5, 2022

Build succeeded:

@bors bors bot merged commit 864538f into STEllAR-GROUP:master Oct 5, 2022
@srinivasyadav18 srinivasyadav18 mentioned this pull request Oct 6, 2022
Merged
bors bot pushed a commit that referenced this pull request Oct 7, 2022
Merge #6035
ba9281d 
6035: Simplify datapar replace copy if r=hkaiser a=srinivasyadav18

Fixes #6033 

## Proposed Changes

  - To use util::in_out_result to return the result from zip_iterator.



Co-authored-by: srinivasyadav18 <srinivasyadav227@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

@aurianer aurianer Awaiting requested review from aurianer

@msimberg msimberg Awaiting requested review from msimberg

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: algorithms type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@srinivasyadav18 @hkaiser