Add cloudflare.secretRef for custom secrets #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove the need to create a secret if the user decides to bring their own secret.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 26.20% 26.20%
=======================================
Files 9 9
Lines 622 622
=======================================
Hits 163 163
Misses 449 449
Partials 10 10 ☔ View full report in Codecov by Sentry. |
inductor
pushed a commit
to outductor/cloudflare-tunnel-ingress-controller
that referenced
this pull request
Dec 17, 2023
This will remove the need to create a secret if the user decides to bring their own secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the need to create a secret if the user decides to
bring their own secret.
Resolves #56