Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recovery of deleted entities (fixes #88) #156

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

crazyscientist
Copy link
Collaborator

@crazyscientist crazyscientist commented Sep 25, 2023

This commit adds an explicit way to restore deleted entities and an implicit way (i.e. an entity gets un-deleted when changes are posted).

Closes #88.

This commit adds an explicit way to restore deleted entities and an implicit way (i.e. an entity
gets un-deleted when changes are posted).
@der-gabe der-gabe self-requested a review September 27, 2023 07:36
Copy link
Member

@der-gabe der-gabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intermediate review

backend/crud.py Outdated Show resolved Hide resolved
…icit recovery

For the sake of consistency, parts of the suggestion were also applied to schemas.
Copy link
Member

@der-gabe der-gabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise! 🙂 👍

frontend/src/components/inputs/EntityForm.vue Show resolved Hide resolved
frontend/src/plugins/api.js Show resolved Hide resolved
frontend/src/components/EntityList.vue Show resolved Hide resolved
backend/general_routes.py Show resolved Hide resolved
backend/exceptions.py Show resolved Hide resolved
backend/general_routes.py Outdated Show resolved Hide resolved
backend/tests/test_dynamic_routes.py Show resolved Hide resolved
backend/tests/test_dynamic_routes.py Show resolved Hide resolved
@crazyscientist crazyscientist merged commit 8907b27 into SUSE:master Oct 19, 2023
2 checks passed
@crazyscientist crazyscientist deleted the 88-undelete branch October 19, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle deleted entities
2 participants