Changes to support kubecf #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the minimal BPM hooks to let things run. This is necessary as quarks-operator does not support non-BPM jobs.
We need `-L` for libdb to be found; we also require a `soelim` executable (which normally comes in the `groff` package) for the build to succeed. As we don't actually need the output (documentation), just write a stub that does nothing instead.
In the quarks world, we do not have co-located jobs (since each job runs in an independent container). Instead, we can vendor the CLI package so that it is visible in the nfsbrokerpush job.
Mounting NFS volumes requires rpc.statd to be running (for lock management). As we run each job in a separate container, we cannot just add jobs for them (as then rpc.statd would not be able to communicate with rpcbind correctly). Instead, just spawn them in the nfsv3driver startup script; they will background themselves. Also, remove the logging redirects, as logging to stdout/stderr is more useful in a containerized scenario.
If the pre-start script is named bin/pre-start, it will (also) be run as a BOSH pre-start script (in addition to being run as a BPM pre-start script); quarks-operator will in this case mount /var/vcap/data/voldrivers as read-only, which breaks the pre-start script. Only use it as a BPM pre-start script instead to ensure that the volume is mounted read-write.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial changes to support cloudfoundry-incubator/kubecf#382.
This will also need changes to
mapfs-release(to be BPM-compatible), plus KubeCF-side changes to use this code. It also requires some sort of resolution for cloudfoundry-incubator/quarks-operator#963.Hopefully the commit messages are clear enough to be able to explain why they are needed.