Fix python3.10 tests #161
Merged
Fix python3.10 tests #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimi1vx
force-pushed
the
py310
branch
8 times, most recently
from
9671ce5 to
9a7aad9
Compare
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 79.27% 79.36% +0.08%
==========================================
Files 26 25 -1
Lines 2012 2011 -1
==========================================
+ Hits 1595 1596 +1
+ Misses 417 415 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
grisu48
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
LGTM! I like it that we can get rid of some old stuff that is not needed anymore.
Would way for @asmorodskyi still for approval though before merging.
asmorodskyi
reviewed
Sep 8, 2022
asmorodskyi
reviewed
Sep 8, 2022
asmorodskyi
reviewed
Sep 8, 2022
asmorodskyi
reviewed
Sep 8, 2022
mimi1vx
force-pushed
the
py310
branch
2 times, most recently
from
95fcb2d to
575b108
Compare
asmorodskyi
reviewed
Sep 10, 2022
ocw/lib/azure.py
Outdated
| @@ -206,7 +206,7 @@ def cleanup_images_from_rg(self, keep_images): | |||
| if self.dry_run: | |||
| self.log_info("Deletion of image {} skipped due to dry run mode", item.name) | |||
| else: | |||
| self.compute_mgmt_client().images.delete(self.__resource_group, item.name) | |||
| self.compute_mgmt_client().images.begin_delete(self.__resource_group, item.name) | |||
There was a problem hiding this comment.
how this appears here ? Looks like some mess in your commits tree , this change already in master e6143d5
asmorodskyi
reviewed
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://progress.opensuse.org/issues/113513