Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes-client version in k8s containers #395

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

pdostal
Copy link
Collaborator

@pdostal pdostal commented Jul 16, 2024

No description provided.

@grisu48
Copy link
Collaborator

grisu48 commented Jul 16, 2024

LGTM but a comment on the wording: I think "Update kubernetes-client" is the better sentence. "Fix" suggests that there was something broken, so it should describe what the problem was that has been fixed, not the action that has been taken.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (51e86da) to head (e48fe12).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files          22       22           
  Lines        1717     1717           
=======================================
  Hits         1347     1347           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdostal pdostal changed the title Fix kubernetes-client version in k8s containers Update kubernetes-client version in k8s containers Jul 16, 2024
@pdostal
Copy link
Collaborator Author

pdostal commented Jul 16, 2024

Sorry, I did the same mistake yesterday and few hours ago I do it again. Updated.

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you try to build the image locally?

Eventually we have to update google-cloud-cli soon.

@pdostal pdostal added the wip Work in progress label Jul 16, 2024
@pdostal
Copy link
Collaborator Author

pdostal commented Jul 16, 2024

One hour ago:

$ podman run -it --rm registry.suse.com/bci/python:3.11
3a45e6c54be4 zypper se kubernetes
Trying to pull registry.suse.com/bci/python@sha256:1f6c3795c271d8c81f1ae457011b629904c50735a149cd943adb3a45e6c54be4...
Getting image source signatures
Checking if image destination supports signatures
Copying blob 2a3e9863a634 done   |
Copying blob d07ceef63959 done   |
Copying config 74f3a21e8d done   |
Writing manifest to image destination
Storing signatures
Refreshing service 'container-suseconnect-zypp'.
Retrieving repository 'SLE_BCI' metadata ....................................................................................................[done]
Building repository 'SLE_BCI' cache .........................................................................................................[done]
Loading repository data...
Reading installed packages...

S | Name                                       | Summary                                                               | Type
--+--------------------------------------------+-----------------------------------------------------------------------+--------
  | kubernetes1.28-client                      | Kubernetes client tools                                               | package
  | kubernetes1.28-client-common               | Kubernetes client tools common files                                  | package
  | python3-azure-mgmt-hybridkubernetes        | Microsoft Azure HybridKubernetes Management Client Library for Python | package
  | python3-azure-mgmt-kubernetesconfiguration | Microsoft Azure Kubernetes Configuration Management Client Library    | package
  | python3-kubernetes                         | Kubernetes python client                                              | package

Now:

$ podman run -it --rm registry.suse.com/bci/python:3.11 zypper se kubernetes
Refreshing service 'container-suseconnect-zypp'.
Retrieving repository 'SLE_BCI' metadata ....................................................................................................[done]
Building repository 'SLE_BCI' cache .........................................................................................................[done]
Loading repository data...
Reading installed packages...

S | Name                                       | Summary                                                            | Type
--+--------------------------------------------+--------------------------------------------------------------------+--------
  | kubernetes1.18-client                      | Kubernetes client tools                                            | package
  | kubernetes1.18-client-common               | Kubernetes client tools common files                               | package
  | python3-azure-mgmt-kubernetesconfiguration | Microsoft Azure Kubernetes Configuration Management Client Library | package
  | terraform-provider-kubernetes              | Terraform Kubernetes provider                                      | package

@pdostal
Copy link
Collaborator Author

pdostal commented Jul 16, 2024

Successfully tagged localhost/suse/qac/pcw-k8s-cleaner:latest
a0d6f1aad26ab0325366ed153bf7f50be1c14d12ef6a785340faf41f698783e4

@pdostal pdostal removed the wip Work in progress label Jul 16, 2024
@asmorodskyi asmorodskyi merged commit d051d0c into SUSE:master Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants