-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes-client version in k8s containers #395
Conversation
LGTM but a comment on the wording: I think "Update kubernetes-client" is the better sentence. "Fix" suggests that there was something broken, so it should describe what the problem was that has been fixed, not the action that has been taken. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 22 22
Lines 1717 1717
=======================================
Hits 1347 1347
Misses 370 370 ☔ View full report in Codecov by Sentry. |
Sorry, I did the same mistake yesterday and few hours ago I do it again. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you try to build the image locally?
Eventually we have to update google-cloud-cli soon.
One hour ago:
Now:
|
|
No description provided.