Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP-S4HA10-setupguide-sle15.adoc sap-nw740-sle15-setupguide.adoc: obsoleted by simple-mount #462

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

lpinne
Copy link
Contributor

@lpinne lpinne commented Nov 20, 2024

Hi,
the two setup guides have been obsoleted by thesimple-mount setup.
However, the old concept still is supported for existing clusters.
The respective note might get published with the next update.
Regards,
Lars

…oleted by simple-mount setup, still supported for existing clusters
Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've made some small suggestions for linguistic updates. Thanks!

adoc/SAP-S4HA10-setupguide-sle15.adoc Outdated Show resolved Hide resolved
adoc/SAP-S4HA10-setupguide-sle15.adoc Outdated Show resolved Hide resolved
adoc/SAP-S4HA10-setupguide-sle15.adoc Outdated Show resolved Hide resolved
adoc/SAP-S4HA10-setupguide-sle15.adoc Outdated Show resolved Hide resolved
adoc/sap-nw740-sle15-setupguide.adoc Outdated Show resolved Hide resolved
adoc/sap-nw740-sle15-setupguide.adoc Outdated Show resolved Hide resolved
adoc/sap-nw740-sle15-setupguide.adoc Outdated Show resolved Hide resolved
adoc/sap-nw740-sle15-setupguide.adoc Outdated Show resolved Hide resolved
adoc/sap-nw740-sle15-setupguide.adoc Outdated Show resolved Hide resolved
@lpinne
Copy link
Contributor Author

lpinne commented Nov 21, 2024

Hi Daria,
looks all good to me.
Thanks!
Lars

@dariavladykina
Copy link
Contributor

Thank you @lpinne , I'll go ahead and commit them then.

Copy link
Contributor

@fsundermeyer fsundermeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tto me! Any objections on merging?

@chabowski chabowski merged commit 0e4062d into main Dec 2, 2024
10 checks passed
@chabowski
Copy link
Collaborator

@lpinne : PR is merged, changes will be published with the next SAP repo builds.
One question: your comment means that we should keep the two docs because they are still valid for existing clusters, correct? We do not need to de-publish them? Thank you!

@tomschr tomschr deleted the lpinne-filesystem branch December 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants