read an autoplotter global mask variable from config file #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2021
EvgeniiChaikin
requested changes
Jun 30, 2021
Collaborator
EvgeniiChaikin
left a comment
EvgeniiChaikin
left a comment
There was a problem hiding this comment.
Hi @james-trayford ,
I've had a look at your changes. Everything looks good but needs rebase. I also left a few small comments
Member
|
Agree with all of Evgenii's comments. |
EvgeniiChaikin
approved these changes
Jul 16, 2021
Collaborator
|
I tested this update (including 3 PRs) again and confirm that everything works as expected. I have nothing else to add. I presume if nobody else wants to add anything, we can finally merge the 3 PRs dealing with the global masking. What do you think @JBorrow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also PRs SWIFTSIM/velociraptor-python#68, SWIFTSIM/pipeline-configs#130