Call spawn with absolute path if the file exists, or relative path if it doesn't #698

ebifrier · 2020-04-17T16:09:49Z

… it doesn't.

yishn · 2020-04-18T11:07:43Z

src/modules/enginesyncer.js

+    let fileExistsSync = path => {
+      try {
+        fs.accessSync(path, fs.F_OK)
+        return true
+      } catch {
+        return false
+      }
+    }


Why not simply use fs.existsSync()?

My understanding is that fs.existsSync is deprecated, but that information was outdated. I modified it to use fs.existsSync. Thanks

yishn · 2020-04-18T12:39:48Z

Thanks a lot for your PR!

Call spawn with absolute path if the file exists, or relative path if…

a538e0b

… it doesn't.

yishn reviewed Apr 18, 2020

View reviewed changes

Use fs.existsSync

cacbe2f

yishn merged commit 4e18b4e into SabakiHQ:master Apr 18, 2020

ebifrier deleted the pathexists branch April 18, 2020 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call spawn with absolute path if the file exists, or relative path if it doesn't #698

Call spawn with absolute path if the file exists, or relative path if it doesn't #698

ebifrier commented Apr 17, 2020 •

edited by yishn

Loading

yishn Apr 18, 2020

ebifrier Apr 18, 2020 •

edited

Loading

yishn commented Apr 18, 2020

Call spawn with absolute path if the file exists, or relative path if it doesn't #698

Call spawn with absolute path if the file exists, or relative path if it doesn't #698

Conversation

ebifrier commented Apr 17, 2020 • edited by yishn Loading

yishn Apr 18, 2020

Choose a reason for hiding this comment

ebifrier Apr 18, 2020 • edited Loading

Choose a reason for hiding this comment

yishn commented Apr 18, 2020

ebifrier commented Apr 17, 2020 •

edited by yishn

Loading

ebifrier Apr 18, 2020 •

edited

Loading