Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to genkernel #62

Merged
merged 3 commits into from
Feb 3, 2018
Merged

Conversation

Dissonant-Tech
Copy link
Contributor

Possible solution to #61

Error caused by not putting spaces between condition in if statement and
braces.
@mudler
Copy link
Member

mudler commented Jan 27, 2018

Thanks! i like the idea of having configurable hooks, and i ack for completeness: if we have to provide this feature should be complete in each phase (as you did).

But i do think that needs to be documented (since we already lack it in some areas)

@Dissonant-Tech
Copy link
Contributor Author

But i do think that needs to be documented

@mudler Not a problem! I'm taking a look at doc/genkernel.8.txt to see where the docs would fit but I'm not too sure. Should there be a new category or under an old one? And if so, where would that category fit?

From what I can tell the best places would either be:

  1. HOOKS category between ACTIONS and OPTIONS
  2. HOOKS category before NETBOOTING
  3. Documentation under ACTIONS since the available actions correlate pretty well with the available hooks.

In any case it will consist of a bit of info on how the hooks work (running all executable scripts in a certain directory) plus a list of available hooks.

Just let me know what sounds best and I'll get on that.

@mudler
Copy link
Member

mudler commented Jan 30, 2018

to me looks fine either way 👍 , feel free to pick one - even tho i'm inclined for 2) since it's a new feature, but 3) sounds also fair as well

@Dissonant-Tech
Copy link
Contributor Author

@mudler I ended up going for 2) as suggested, and in the end I think it was the right option. Let me know if you feel there is anything else missing.

@mudler
Copy link
Member

mudler commented Feb 3, 2018

Thanks! 👍

@mudler mudler merged commit 8aa1858 into Sabayon:master Feb 3, 2018
qinq-net pushed a commit to qinq-net/genkernel-next that referenced this pull request Apr 1, 2019
* Add hooks to genkernel

* Fix mssing 'missing ]' error

Error caused by not putting spaces between condition in if statement and
braces.

* Add HOOKS documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants