From 646044fcdda067b1d20f31cbfbceb98820c36674 Mon Sep 17 00:00:00 2001
From: edleeks87 <edward.leeks@sage.com>
Date: Thu, 3 Oct 2024 13:54:26 +0100
Subject: [PATCH] fix(select): upgrade tanstack react-virtual to latest

Upgrades `@tanstack/react-virtual` to 3.10.8

fix #6978
---
 package-lock.json                                | 16 ++++++++--------
 package.json                                     |  2 +-
 .../select/simple-select/simple-select.spec.tsx  |  4 ++--
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c67076a3c2..10e77c378e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -14,7 +14,7 @@
         "@floating-ui/react-dom": "~1.3.0",
         "@octokit/rest": "^18.12.0",
         "@styled-system/prop-types": "^5.1.5",
-        "@tanstack/react-virtual": "^3.0.0-beta.68",
+        "@tanstack/react-virtual": "^3.6.0",
         "@types/styled-system": "^5.1.22",
         "chalk": "^4.1.2",
         "ci-info": "^3.8.0",
@@ -6982,11 +6982,11 @@
       }
     },
     "node_modules/@tanstack/react-virtual": {
-      "version": "3.2.0",
-      "resolved": "https://registry.npmjs.org/@tanstack/react-virtual/-/react-virtual-3.2.0.tgz",
-      "integrity": "sha512-OEdMByf2hEfDa6XDbGlZN8qO6bTjlNKqjM3im9JG+u3mCL8jALy0T/67oDI001raUUPh1Bdmfn4ZvPOV5knpcg==",
+      "version": "3.10.8",
+      "resolved": "https://registry.npmjs.org/@tanstack/react-virtual/-/react-virtual-3.10.8.tgz",
+      "integrity": "sha512-VbzbVGSsZlQktyLrP5nxE+vE1ZR+U0NFAWPbJLoG2+DKPwd2D7dVICTVIIaYlJqX1ZCEnYDbaOpmMwbsyhBoIA==",
       "dependencies": {
-        "@tanstack/virtual-core": "3.2.0"
+        "@tanstack/virtual-core": "3.10.8"
       },
       "funding": {
         "type": "github",
@@ -6998,9 +6998,9 @@
       }
     },
     "node_modules/@tanstack/virtual-core": {
-      "version": "3.2.0",
-      "resolved": "https://registry.npmjs.org/@tanstack/virtual-core/-/virtual-core-3.2.0.tgz",
-      "integrity": "sha512-P5XgYoAw/vfW65byBbJQCw+cagdXDT/qH6wmABiLt4v4YBT2q2vqCOhihe+D1Nt325F/S/0Tkv6C5z0Lv+VBQQ==",
+      "version": "3.10.8",
+      "resolved": "https://registry.npmjs.org/@tanstack/virtual-core/-/virtual-core-3.10.8.tgz",
+      "integrity": "sha512-PBu00mtt95jbKFi6Llk9aik8bnR3tR/oQP1o3TSi+iG//+Q2RTIzCEgKkHG8BB86kxMNW6O8wku+Lmi+QFR6jA==",
       "funding": {
         "type": "github",
         "url": "https://github.com/sponsors/tannerlinsley"
diff --git a/package.json b/package.json
index 3cca93d604..076ce4e5a9 100644
--- a/package.json
+++ b/package.json
@@ -184,7 +184,7 @@
     "@floating-ui/react-dom": "~1.3.0",
     "@octokit/rest": "^18.12.0",
     "@styled-system/prop-types": "^5.1.5",
-    "@tanstack/react-virtual": "^3.0.0-beta.68",
+    "@tanstack/react-virtual": "^3.10.8",
     "@types/styled-system": "^5.1.22",
     "chalk": "^4.1.2",
     "ci-info": "^3.8.0",
diff --git a/src/components/select/simple-select/simple-select.spec.tsx b/src/components/select/simple-select/simple-select.spec.tsx
index e17f058aa2..9ace614936 100644
--- a/src/components/select/simple-select/simple-select.spec.tsx
+++ b/src/components/select/simple-select/simple-select.spec.tsx
@@ -366,10 +366,10 @@ describe("SimpleSelect", () => {
         });
 
         describe("and the focus triggered by mouseDown", () => {
-          it("then that prop should not be called", () => {
+          it("then that prop should not be called more than once", () => {
             simulateSelectTextboxEvent(wrapper, "mousedown");
             simulateSelectTextboxEvent(wrapper, "focus");
-            expect(onOpenFn).not.toHaveBeenCalled();
+            expect(onOpenFn).toHaveBeenCalledTimes(1);
           });
         });
       });