Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem with Icons misaligned due to padding #7096

Closed
1 task done
nelson-oba-sage opened this issue Nov 26, 2024 · 2 comments · Fixed by #7120
Closed
1 task done

MenuItem with Icons misaligned due to padding #7096

nelson-oba-sage opened this issue Nov 26, 2024 · 2 comments · Fixed by #7120
Labels
Bug On Backlog released

Comments

@nelson-oba-sage
Copy link

nelson-oba-sage commented Nov 26, 2024 •
edited by edleeks87
Loading

Description

some button texts with icons are getting a 2px padding at the bottom, and there's no props available to manipulate the spacing.
image

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-32z3th?file=src%2FApp.tsx

Steps to reproduce

inspect a button with an icon, you'll find there's no way to change the button text padding or relative position within the button

JIRA ticket numbers (Sage only)

SBS-114938

Suggested solution

No response

Carbon version

142.13.1

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@nelson-oba-sage nelson-oba-sage added Bug triage Triage Required labels Nov 26, 2024
@edleeks87 edleeks87 changed the title Buttons with Icons getting 2px padding MenuItem with Icons misaligned due to padding Nov 27, 2024
@tomdavies73
Copy link
Contributor

FE-7014

@tomdavies73 tomdavies73 added On Backlog and removed triage Triage Required labels Dec 3, 2024
damienrobson-sage added a commit that referenced this issue Dec 9, 2024
@damienrobson-sage
feat(menu-item): fix padding when child of Menu and no icon
a1dad87 
When used alongside menu items with icons, icon-less menu items are misaligned

Resolves #7096
@damienrobson-sage damienrobson-sage mentioned this issue Dec 9, 2024
Merged
6 tasks
carbonci pushed a commit that referenced this issue Dec 12, 2024
@semantic-release-bot @carbonci
chore(release): 144.21.0
ef93fd9 
## [144.21.0](v144.20.1...v144.21.0) (2024-12-12)

### Features

* **menu-item:** fix padding when child of Menu and no icon ([adb4c34](adb4c34)), closes [#7096](#7096)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 144.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu-item): fix padding when child of Menu and no icon Sage/carbon
3 participants
@carbonci @tomdavies73 @nelson-oba-sage