Add Ruby 3.3 to CI tests #119
Conversation
.github/workflows/ci.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| name: Ruby ${{ matrix.ruby }} | |||
| strategy: | |||
| matrix: | |||
| ruby: ["2.6", "2.7", "3.0", "3.1", "3.2"] | |||
| ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"] | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
While you're at it (prevents node deprecation warnings)
| - uses: actions/checkout@v3 | |
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Thanks, changed. Can you point me where can I see this deprecation?
There was a problem hiding this comment.
Yeah, sure. Here's the run from when you opened this PR: https://github.com/SamSaffron/memory_profiler/actions/runs/9553006533
You can either go there from the Repo Actions tab and look for it there, or click on "Checks" for this PR and then "CI" to go to the summary tab.
GitHub doesn't make these notices very obvious, the amount of worklflows that still use v2/v3 is astronomical. There are also other actions with major bumps like this ofc but this one is the most prevalent I'd say.
There was a problem hiding this comment.
Ah, thanks. I looked in the wrong place originally (each job details) and haven't noticed any.
|
I am fine to remove all EOL rubies, I don't care to test them, this means we only test on 3.1 and up. |
No description provided.