Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneExplorer] Keep selected files in default explorer view #1126

Open
dayo09 opened this issue Aug 2, 2022 · 3 comments
Open

[OneExplorer] Keep selected files in default explorer view #1126

dayo09 opened this issue Aug 2, 2022 · 3 comments
Labels

Comments

@dayo09
Copy link
Contributor

dayo09 commented Aug 2, 2022

What?

Let's keep selected file while moving from one explorer view to default explorer view.
So the user can just select any file and locate it under default file explorer view.

Why?

Basically, One Explorer is a view which helps users to use onecc easily.
It's not a file explorer.
User may want to look at the file's location in the file explorer view.
Let's support users to switch between OneExplorer and default vscode explorer while keeping the file selection.

POINT1 If any file is opened, it's selected in default explorer view, automatically.

For example, there are some files that are supported to open in a view : *.log.
Those files are kept in its selection while user moves to vscode explorer.
In other word, if OneExplorer supports editors(openViewTypes) for all the files it supports, the feature will be automatically supported, too.

POINT2

The feature : "Get selected file/folder in the explorer view" seems not being officially support yet

microsoft/vscode#3553

@dayo09 dayo09 added the Future label Aug 2, 2022
@dayo09
Copy link
Contributor Author

dayo09 commented Aug 23, 2022

@lemmaa FYI, from the short research, it seems not to be possible to "select a file from One Explorer and show in default explorer". Vscode's api doesn't support it.

By workaround, we can make it to 'open every file' in editors. If it's kept opened in any editor, default explorer can 'select' it automatically. But I doubt that's the one you look for. 😢 Because it will open 'editor not supported' files.

@lemmaa
Copy link
Member

lemmaa commented Aug 24, 2022

Let's support users to switch between OneExplorer and default vscode explorer while keeping the file selection.

Oh, I think your idea is cool. If all the files we deal with have an appropriate editor, it will be a natural and useful experience.

Regarding the display of selected files on the Explorer View, I was just expecting the "Reveal in Explorer View" function of the file tab to be added to the context menu of ONE Explorer. This is probably not a problem with the current implementation. :)

@dayo09
Copy link
Contributor Author

dayo09 commented Aug 24, 2022

@lemmaa

For sure. 😄 "Reveal in Explorer View" command is implemented in #1234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants